Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mtl] Fix A2BGR10 format mapping #2336

Merged
merged 3 commits into from
Aug 24, 2018
Merged

[mtl] Fix A2BGR10 format mapping #2336

merged 3 commits into from
Aug 24, 2018

Conversation

kvark
Copy link
Member

@kvark kvark commented Aug 23, 2018

Fixes Dota2 after #2116
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:
  • rustfmt run on changed code

Thomspoon
Thomspoon suggested changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@Thomspoon Thomspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to get rid of the RGB10A2Uint format.

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

You don't want to get rid of the RGB10A2Uint format.

It would need to be mapped to BGR10A2Uint, which doesn't exist

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

bors delegate=Thomspoon

@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

✌️ Thomspoon can now approve this pull request

@Thomspoon
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

👎 Rejected by code reviews

@Thomspoon
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
f29ca84 
2336: [mtl] Fix A2BGR10 format mapping r=Thomspoon a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@grovesNL
Copy link
Contributor

bors r=Thomspoon

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
db2144b 
2336: [mtl] Fix A2BGR10 format mapping r=Thomspoon a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

jeez, CI, get your sht together!
bors retry

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
e0ea3a6 
2336: [mtl] Fix A2BGR10 format mapping r=Thomspoon a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@grovesNL
Copy link
Contributor

AppVeyor's failure is a bit strange:

cargo check --all  --exclude gfx-backend-metal --exclude gfx-warden
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading log v0.4.4
error: unable to get packages from source
Caused by:
  [35] SSL connect error (schannel: next InitializeSecurityContext failed: Unknown error (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.)

bors retry

@grovesNL
Copy link
Contributor

Hmm, why doesn't retry work there?

bors r=Thomspoon

@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Not awaiting review

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
5c98d95 
2336: [mtl] Fix A2BGR10 format mapping r=Thomspoon a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

Added one extra commit for filtering the copy regions, since apparently some apps want to pass zero dimensions there, and I don't see Vulkan spec forbidding that.
bors r+

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
f87b721 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

ALL CI IS BROKEN
bors retry

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
fae706e 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
2712a35 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018 via email

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
e8a1474 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018 via email

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
1094ed0 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 23, 2018 via email

bors bot added a commit that referenced this pull request Aug 23, 2018
@bors @kvark
Merge #2336
cf9f397 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 24, 2018 via email

bors bot added a commit that referenced this pull request Aug 24, 2018
@bors @kvark
Merge #2336
592139e 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2018

Build failed

@kvark
Copy link
Member Author

kvark commented Aug 24, 2018

bors retry

bors bot added a commit that referenced this pull request Aug 24, 2018
@bors @kvark
Merge #2336
4d6fd4d 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2018

Build failed

@kvark kvark mentioned this pull request Aug 24, 2018
Merged
@kvark
Copy link
Member Author

kvark commented Aug 24, 2018 via email

bors bot added a commit that referenced this pull request Aug 24, 2018
@bors @kvark
Merge #2336
184273d 
2336: [mtl] Fix A2BGR10 format mapping r=kvark a=kvark

Fixes Dota2 after #2116 
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2018

Build succeeded

@bors bors bot merged commit 588384b into gfx-rs:master Aug 24, 2018
@kvark kvark deleted the mtl-a2 branch August 24, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomspoon Thomspoon Thomspoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvark @Thomspoon @grovesNL