-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order of HLSL Semantics Issues #1945
Labels
area: back-end
Outputs of shader conversion
kind: bug
Something isn't working
lang: HLSL
High-Level Shading Language
Comments
cwfitzgerald
added
kind: bug
Something isn't working
area: back-end
Outputs of shader conversion
lang: HLSL
High-Level Shading Language
labels
May 27, 2022
I'm not sure if this is worth fixing, as it violates a WebGPU rule about mismatched inputs and outputs. See the mentioned wgpu issue. |
Aaron1011
added a commit
to Aaron1011/wgpu
that referenced
this issue
Sep 5, 2023
This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12.
3 tasks
Aaron1011
added a commit
to Aaron1011/wgpu
that referenced
this issue
Sep 5, 2023
This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12.
Aaron1011
added a commit
to Aaron1011/wgpu
that referenced
this issue
Sep 20, 2023
This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12.
cwfitzgerald
pushed a commit
to gfx-rs/wgpu
that referenced
this issue
Sep 21, 2023
) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
Aaron1011
added a commit
to ruffle-rs/wgpu
that referenced
this issue
Sep 30, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this issue
Oct 9, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this issue
Oct 9, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this issue
Oct 10, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: back-end
Outputs of shader conversion
kind: bug
Something isn't working
lang: HLSL
High-Level Shading Language
Seems like gfx-rs/wgpu#5553 has reared its head again.
Given these wgsl shaders:
vertex: https://github.com/BVE-Reborn/rend3/blob/wgpu-upgrade-0.13/rend3-routine/shaders/wgsl/depth.vert.cpu.wgsl
fragment: https://github.com/BVE-Reborn/rend3/blob/wgpu-upgrade-0.13/rend3-routine/shaders/wgsl/depth-cutout.frag.cpu.wgsl
Generate the following HLSL:
vert.hlsl
frag.hlsl
The text was updated successfully, but these errors were encountered: