Fix SPIR-V back-end, width will now be multiplied by 8 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
Timo-DK
force-pushed
the
multiply-width-fix
branch
from
71bd05b to
321dc95
Compare
kvark
requested changes
Jul 12, 2020
Timo-DK
force-pushed
the
multiply-width-fix
branch
from
321dc95 to
ed29d47
Compare
Timo-DK
force-pushed
the
multiply-width-fix
branch
from
ed29d47 to
15f544e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change of the bits to Bytes in the IR, the SPIR-V back-end failed to correctly validate OpTypeFloat and OpTypeInt. Their width operand requires the bits, not the bits.