Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather operations #1596

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Gather operations #1596

merged 1 commit into from
Dec 18, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Dec 15, 2021

Closes #1570
See gpuweb/gpuweb#2327
Doesn't implement parsing new SPV-in or GLSL-in instructions, but covers all backends and WGSL-in.

@kvark kvark force-pushed the gather branch 2 times, most recently from ab133ea to 8467e8c Compare December 16, 2021 04:25
@kvark kvark marked this pull request as ready for review December 16, 2021 04:25
@kvark kvark mentioned this pull request Dec 17, 2021
@kvark kvark force-pushed the gather branch 2 times, most recently from ded3ee4 to 08961c6 Compare December 18, 2021 01:37
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, looks great! Just a few thoughts.

src/valid/expression.rs Show resolved Hide resolved
src/front/wgsl/mod.rs Show resolved Hide resolved
src/back/msl/writer.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texture gather functions
2 participants