Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spv-in: Implement more sign agnostic operations #1651

Merged
merged 2 commits into from
Jan 7, 2022
Merged

spv-in: Implement more sign agnostic operations #1651

merged 2 commits into from
Jan 7, 2022

Conversation

JCapucho
Copy link
Collaborator

@JCapucho JCapucho commented Jan 7, 2022 •
edited
Loading

Only missing the shift operations but those require some special attention.

Closes #1645

kvark
kvark approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean, well done!

@kvark kvark merged commit eeb3de6 into gfx-rs:master Jan 7, 2022
@kvark kvark added the can backport PR that can be back-ported to a release branch label Jan 7, 2022
@kvark kvark mentioned this pull request Jan 12, 2022
Merged
@kvark
Copy link
Member

kvark commented Jan 12, 2022

Published in naga-0.8.2

@kvark kvark removed the can backport PR that can be back-ported to a release branch label Jan 12, 2022
@JCapucho JCapucho deleted the spv-unary-sign branch February 19, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spirv-in] More sign-agnostic operations
2 participants
@JCapucho @kvark