Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-structure buffer types #1682

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Allow non-structure buffer types #1682

merged 1 commit into from
Feb 2, 2022

Conversation

kvark
Copy link
Member

@kvark kvark commented Jan 21, 2022

@kvark kvark requested a review from jimblandy January 21, 2022 17:30
@kvark kvark force-pushed the buffer-types branch 2 times, most recently from f4e158c to 508d29a Compare January 24, 2022 21:57
jimblandy
jimblandy approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a problem with how we emit cbuffer declarations in HLSL, but other than that, this looks good.

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
tests/out/spv/globals.spvasm Outdated Show resolved Hide resolved
@kvark kvark enabled auto-merge (rebase) February 2, 2022 15:06
@kvark kvark merged commit 75692d3 into gfx-rs:master Feb 2, 2022
@jimblandy jimblandy mentioned this pull request Apr 7, 2022
Closed
@teoxoy teoxoy mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvark @jimblandy