glsl-in: Texture builtins fixes #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Feb 7, 2022
This one grew out of hand quick. Initially it was just replacing the bit loops with a function driving the declarations to make the code sharing better and support different scalar kinds. Now it includes a lot of fixes: - `textureSize` now also returns the array layers as the last component on the return (only for arrayed textures) - `textureSize` now supports multisampled textures - the `texture` family of functions now consumes a `vec3` coordinate vector for all 1D shadow textures - Shadow textures can use the bias version of `texture` functions (temporarily disabled since naga doesn't support it) - 3D textures can be used in `textureProj` - `sampler2DArrayShadow` can't be used in `textureLod` or in `texture` with bias - Cube textures cannot be used with offsets Updates the tests to cover all functions
JCapucho
force-pushed
the
glsl-texture-fixes
branch
from
71f8e25
to
ecc711a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one grew out of hand quick. Initially it was just replacing the bit
loops with a function driving the declarations to make the code sharing
better and support different scalar kinds.
Now it includes a lot of fixes:
textureSizenow also returns the array layers as the last componenton the return (only for arrayed textures)
textureSizenow supports multisampled texturestexturefamily of functions now consumes avec3coordinatevector for all 1D shadow textures
texturefunctions(temporarily disabled since naga doesn't support it)
textureProjsampler2DArrayShadowcan't be used intextureLodor intexturewith biasUpdates the tests to cover all functions