msl: qualify read-only storage with const #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
reviewed
Mar 7, 2022
There was a problem hiding this comment.
Looks good to me.
It's helpful to separate out the changes to the tests into a separate commit, so that the effects of the changes to the code are completely apparent. I'm more likely to miss something when (say) the const qualifiers are mixed in with a lot of renames and code movement.
| } | ||
| } | ||
|
|
||
| /// Returns true if the address space may need a "const" qualifier. |
There was a problem hiding this comment.
I'm in the dark as to why, say, Uniform and PushConstant don't need const. Is it because their MSL address space alone implies that they're not writable, so const is unnecessary, unlike Storage, Private, and WorkGroup, which could be writable?
There was a problem hiding this comment.
Added a comment here, and made the MSL output actually contain push constants for the test, in #1767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761