Explicitely enable std for indexmap #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
Okay - I see that indexmap on master actually makes std default, but the 1.8.1 release that Naga is using right now still uses autocfg to check the CARGO_FEATURE_STD environment variable. So once Naga is able to switch to indexmap 2.0.0, we can remove this.
Thanks!
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Jul 23, 2024
This was added in gfx-rs/naga#2062 This was needed before version 2, but not in version 2, so it should be safe to remove now as it is enabled by default.
6 tasks
ErichDonGubler
pushed a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Jul 24, 2024
This was added in gfx-rs/naga#2062 This was needed before version 2, but not in version 2, so it should be safe to remove now as it is enabled by default.
teoxoy
pushed a commit
to gfx-rs/wgpu
that referenced
this pull request
Jul 24, 2024
This was added in gfx-rs/naga#2062 This was needed before version 2, but not in version 2, so it should be safe to remove now as it is enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that depending on the environment the std check by the autocfg crate may fail. This enables std like recommended here: indexmap-rs/indexmap#184