Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rgb10a2Uint format #2525

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add Rgb10a2Uint format #2525

merged 1 commit into from
Oct 3, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 2, 2023

Also fixes a few usages of the wrong format Rgb10a2 formats.

Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM1! Nice to knock out yet another standards gap. 🙂 Guessing we need a Firefox bug for this, too?

Footnotes

  1. …though I don't have merge rights yet; @jimblandy, I guess we can do this, now that I have wgpu perms. already?)

@teoxoy
Copy link
Member Author

teoxoy commented Oct 3, 2023

STORAGE_BINDING on the format is not supported yet (gpuweb/gpuweb#3837). I noticed we were using the wrong format for Rgb10a2Unorm in a few places and ended up adding Rgb10a2Uint now for completeness.

Guessing we need a Firefox bug for this, too?

Hmm, I think we do, we'd need to add it to the bindings but we need to add it to wgpu first.

@teoxoy teoxoy merged commit 6668d06 into gfx-rs:master Oct 3, 2023
6 checks passed
@teoxoy teoxoy deleted the add-Rgb10a2Uint branch October 3, 2023 11:36
@teoxoy teoxoy mentioned this pull request Oct 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants