compact: Don't assume Emitted expressions are live. #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify visibility markings. - Remove some testing comments. (Tests carried out.) - Remove some commented-out code.
If an `Emit` statement covers an `Expression` that is not otherwise used by any `Statement`, remove it from the `Arena` anyway. An `Emit` statement controls when `Expression`s are evaluated, but it doesn't have any side effects, so unless an expression is used by some other statement, it's not necessary to the program.
teoxoy
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
Emitstatement covers anExpressionthat is not otherwiseused by any
Statement, remove it from theArenaanyway. AnEmitstatement controls when
Expressions are evaluated, but it doesn'thave any side effects, so unless an expression is used by some other
statement, it's not necessary to the program.
compact: Minor cleanups.
Simplify visibility markings.
Remove some testing comments. (Tests carried out.)
Remove some commented-out code.