allow handling errors for spirv and glsl shader #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently only the shader parse errors in
wgslare catch-able via error-scopes / uncaptured-error-callback. If parse errors forspirv&glsloccur the library panics here & here.This PR fixes it by making sure such errors goes through typical error scopes. Though keep in mind that, if the reported error is ignored and the invalid shader module object is passed to further functions (
wgpuDeviceCreateComputePipeline,wgpuDeviceCreateRenderPipeline), those functions will panic immediately instead of "error-ing".Testing
tested with an invalid glsl shader