Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gnu Windows/iOS/Android builds and improve continuous delivery workflow #405

Merged

Conversation

ygdrasil-io
Copy link
Contributor

@ygdrasil-io ygdrasil-io commented Aug 5, 2024

  • Upgrade Upload and Download Actions to v4
  • Simplify existing builds using a matrix strategy
  • Add Windows x64 GNU build configuration
  • Add iOS build configuration
  • Add Android build configuration

- Upgrade Upload and Download Actions to v4
- Simplify existing builds using a matrix strategy
- Add Windows x64 GNU build configuration
- Add iOS build configuration
- Add Android build configuration
@ygdrasil-io ygdrasil-io force-pushed the feature/gnu-windows-static-library branch from da5fc71 to e6e633f Compare August 17, 2024 18:07
@ygdrasil-io ygdrasil-io changed the title add gnu Windows build add gnu Windows/iOS/Android builds and improve continuous delivery workflow Aug 17, 2024
@ygdrasil-io
Copy link
Contributor Author

For testing purposes, I created a fake release. If necessary, you can find the new builds here:
https://github.com/ygdrasil-io/wgpu-native/releases/tag/v0.0.0.1

@ygdrasil-io
Copy link
Contributor Author

https://github.com/ygdrasil-io/wgpu-native/releases/tag/v0.0.0.2 (There was a typo on Macos release)

The android version is working well :
image

@almarklein
Copy link
Collaborator

This is great! I reviewed your changes, and it looks fine to me. Can you please also update the description at the top? It says "Each target (os + architecture) is build in a seperate job." but this is no longer the case.

Since this change is potentially impactful, I prefer to first merge #402 and do a release, then merge this pr and do another release.

@almarklein
Copy link
Collaborator

We can combine this with #410

@almarklein
Copy link
Collaborator

Note: #411 will probably introduce merge conflicts.

@almarklein almarklein mentioned this pull request Aug 27, 2024
ygdrasil-io and others added 3 commits August 28, 2024 00:36
Updated the Android NDK version from 25.2.9519653 to 27.0.12077973 across all target architectures in the GitHub Actions CI/CD pipeline. This change ensures compatibility with the latest NDK features and improvements. The `LIBCLANG_PATH` environment variable was also removed as it was no longer being utilized.
@ygdrasil-io
Copy link
Contributor Author

@almarklein If you have the permissions, could you please retry the failing job? The cloning of the Git repository https://github.com/glfw/glfw.git seems to have failed for some reason.

@almarklein almarklein merged commit 71bc33b into gfx-rs:trunk Aug 29, 2024
16 checks passed
@almarklein
Copy link
Collaborator

Awesome work, thanks! 🚀

@ygdrasil-io ygdrasil-io deleted the feature/gnu-windows-static-library branch August 29, 2024 08:54
@almarklein
Copy link
Collaborator

Out of curiosity, do you know why the linux-aarch64 build takes abour half an hour, while all other builds take less than 4 minutes (most less than 1 min)? Would it be due to emulating arm64 on x86?

@ygdrasil-io
Copy link
Contributor Author

I think you are right, on my Mac Studio I see the same behaviour when I'm running a x86 VM, while arm VM are almost as quick of the host OS.

May be we could try cross compilation over virtualisation ?

@almarklein
Copy link
Collaborator

It's not the end of the world, I was mostly curious because that one build stands out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants