This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
[Blocked] Relax render/compute pass lifetimes #604
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly reverts #168 given that
wgpu-core
is now properly handling error IDs.Closes #603
Closes #188
Has a major positive usability impact 🚆 It is no longer required by the type system to keep resources alive for the duration of a render/compute pass encoding. It's still required by the runtime: dropping a pass will produce an error if some of the dependencies are dropped before it.
Looking at the error messages may be difficult until an approach similar to gfx-rs/wgpu#931 (comment) is rolled out in wgpu-rs (cc @scoopr). We'll make it a priority before releasing wgpu-0.7.
Edit: actually, the IDs here are not "error IDs" that
wgpu-core
handles. It will panic straight upon seeing such a stale ID...