Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot use rgba16float on gles backend #2089

Closed
m4b opened this issue Oct 17, 2021 · 2 comments
Closed

cannot use rgba16float on gles backend #2089

m4b opened this issue Oct 17, 2021 · 2 comments
Labels
area: correctness We're behaving incorrectly type: bug Something isn't working

Comments

@m4b
Copy link
Contributor

m4b commented Oct 17, 2021

Attempting to use results in this error:

GLES: [API/Error] ID 1 : GL_INVALID_OPERATION in glTexSubImage2D(format = GL_RG, type = GL_HALF_FLOAT, internalformat = GL_RGBA16F)

As pointed in chat, this line appears wrong:

wgpu/wgpu-hal/src/gles/conv.rs

Line 48 in 47fb0ef

Tf::Rgba16Float => (glow::RGBA16F, glow::RG, glow::HALF_FLOAT),

Filing this so it's tracked.
@kvark
Copy link
Member

kvark commented Oct 18, 2021

Would you want to make a PR?

@kvark kvark added area: correctness We're behaving incorrectly type: bug Something isn't working labels Oct 18, 2021
@aloucks
Copy link
Contributor

aloucks commented Dec 13, 2021

Looks like this was fixed in #2136

cwfitzgerald pushed a commit that referenced this issue Oct 25, 2023
@SparkyPotato @teoxoy @jimblandy
[wgsl-in] Implement module-level scoping.
6035b07 
Fixes #1745: Support out-of-order module scope declarations in WGSL
Fixes #1044: Forbid local variable shadowing in WGSL
Fixes #2076: [wgsl-in] no error for duplicated type definition
Fixes #2071: Global item does not support 'const'
Fixes #2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes #1775: Referencing a function without a return type yields an unknown identifier error.
Fixes #2089: Error span reported on the declaration of a variable instead of its use
Fixes #1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvark @aloucks @m4b @cwfitzgerald