gles backend: unbind PIXEL_UNPACK_BUFFER #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me on top of master in Firefox/Chrome on Windows, and importantly it is broken for me before this PR. |
mrk-its
force-pushed
the
unbind_unpack_buffer
branch
from
685c7a6
to
50bb59f
Compare
kvark
approved these changes
Nov 9, 2021
|
Published in wgpu-hal-0.11.5 |
kvark
removed
the
PR: needs back-porting
kvark
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometime texSubImage doesn't work and following error is shown in the logs:
WebGL warning: texSubImage: Tex upload from non-PBO but PIXEL_UNPACK_BUFFER was bound..Testing
This issue is visible in bevy's
load_gltf_pipelinedexample on this branch: https://github.com/mrk-its/bevy/tree/pipelined-pbr-webgl2