do not query work group params on gles < 3.1 #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Nov 9, 2021
mrk-its
changed the title
mrk-its
changed the title
mrk-its
changed the title
mrk-its
force-pushed
the
gles_wasm32_invalid_enum
branch
from
672059f
to
6633302
Compare
mrk-its
force-pushed
the
gles_wasm32_invalid_enum
branch
from
6633302
to
8d4d0a3
Compare
kvark
added
the
PR: needs back-porting
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Dec 2, 2021
* do not query work group params on gles < 3.1 * address reviewer comment
|
Published in wgpu-hal-0.11.5 |
kvark
removed
the
PR: needs back-porting
kvark
pushed a commit
that referenced
this pull request
Dec 2, 2021
* do not query work group params on gles < 3.1 * address reviewer comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gles backend queries
MAX_COMPUTE_WORK_GROUP_COUNTandMAX_COMPUTE_WORK_GROUP_SIZEparameters generatinggetIndexedParameter: Badpname: Invalid enum valuewarnings. This PR disables these queries on wasm32 and setsmax_compute_workgroup_size_*andmax_compute_workgroups_per_dimensionto0
Testing
It can be tested on wgpu
cubeexample