Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/vk: add physical device features for extensions #2167

Merged
merged 1 commit into from
Nov 9, 2021
Merged

hal/vk: add physical device features for extensions #2167

merged 1 commit into from
Nov 9, 2021

Conversation

msiglreith
Copy link
Contributor

Description
For some extensions the corresponding physical device features haven't been added in the feature chain.
Vulkan Validation Error on Android:

11-08 17:40:16.747 20431 20479 I RustStdoutStderr: VUID-VkSemaphoreTypeCreateInfo-timelineSemaphore-03252(ERROR / SPEC): msgNum: 963335225 - Validation Error: [ VUID-VkSemaphoreTypeCreateInfo-timelineSemaphore-03252 ] Object 0: handle = 0x7b05719180, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x396b5439 | VkCreateSemaphore: timelineSemaphore feature is not enabled, can not create timeline semaphores The Vulkan spec states: If the timelineSemaphore feature is not enabled, semaphoreType must not equal VK_SEMAPHORE_TYPE_TIMELINE (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkSemaphoreTypeCreateInfo-timelineSemaphore-03252)

Testing
Tested on Android and Windows using Vulkan backend.

kvark
kvark approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kvark kvark merged commit 6fc0587 into gfx-rs:master Nov 9, 2021
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Nov 9, 2021
@msiglreith msiglreith deleted the vk-features-ext branch November 9, 2021 15:23
kvark pushed a commit to kvark/wgpu that referenced this pull request Dec 2, 2021
@msiglreith @kvark
hal/vk: add physical device features for extensions (gfx-rs#2167)
89abe09
@kvark kvark mentioned this pull request Dec 2, 2021
Merged
@kvark
Copy link
Member

kvark commented Dec 2, 2021

Published in wgpu-hal-0.11.5

@kvark kvark removed the PR: needs back-porting PR with a fix that needs to land on crates label Dec 2, 2021
kvark pushed a commit that referenced this pull request Dec 2, 2021
@msiglreith @kvark
hal/vk: add physical device features for extensions (#2167)
343b1ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msiglreith @kvark