Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate sampling pairs for validation #2188

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 17, 2021

Connections
Fixes #2182

Description
We didn't populate the set

Testing
Modified the skybox example:

Caused by:
    In Device::create_render_pipeline
      note: label = `Sky`
    error matching FRAGMENT shader requirements against the pipeline
    unable to filter the texture (ResourceBinding { group: 0, binding: 1 }) by the sampler (ResourceBinding { group: 0, binding: 2 })
    non-filterable float texture

@Jerrody
Copy link

Jerrody commented Nov 18, 2021

Hey, in Rust was added some syntax sugar with that you can iter over an array without explicitly writing iter().
Like:

            for key in info.sampling_set {
                ep.sampling_pairs
                    .insert((resource_mapping[&key.image], resource_mapping[&key.sampler]));
            }

@kvark
Copy link
Member Author

kvark commented Nov 19, 2021

Oh yes, I'm well aware, just like my iterators explicit.

@kvark kvark merged commit fca82dd into gfx-rs:master Nov 19, 2021
@kvark kvark deleted the pair-valid branch November 19, 2021 00:06
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Nov 19, 2021
kvark added a commit to kvark/wgpu that referenced this pull request Dec 2, 2021
@kvark
Copy link
Member Author

kvark commented Dec 2, 2021

Published in wgpu-core-0.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sampling_pairs validation doesn't actually get populated and thus doesn't work
2 participants