Web: pass correct size argument to setIndexBuffer and setVertexBuffer #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size must be passed to setIndexBuffer in Javascript as undefined in order for WebGGPU to use the default size, which is the full buffer size.
kvark
approved these changes
Nov 22, 2021
cwfitzgerald
added
the
PR: needs back-porting
|
Published in wgpu-0.11.1 |
kvark
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Chrome Canary started validating the
sizeargument in the methodssetIndexBufferandsetVertexBufferonGPURenderEncoderBase. This PR corrects an issue wherewgpuwas passingsizeas0when the BufferSlice was open-ended. In that case,sizeshould be passed asundefined.Testing
Run some of the web examples using WebGPU and Chrome Canary
98.0.4720.0or later.