Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal/vulkan: use multiple semaphores in a relay #2212

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 25, 2021

Connections
Attempting to work around #1672, which is currently blocking gecko.
https://phabricator.services.mozilla.com/D132058

Description
Intel apparently doesn't like that the same semaphore is both waited upon and signaled.
This PR makes it 2 semaphores, which we use in ping-pong fashion.

Testing
On Gecko

@kvark
Copy link
Member Author

kvark commented Nov 25, 2021

Confirmed this to make vange-rs work.

@kvark kvark merged commit 5f6c067 into gfx-rs:master Nov 25, 2021
@kvark kvark deleted the workaround branch November 25, 2021 20:45
@kvark kvark restored the workaround branch November 25, 2021 20:52
@kvark kvark deleted the workaround branch December 2, 2021 01:30
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Dec 2, 2021
kvark added a commit to kvark/wgpu that referenced this pull request Dec 2, 2021
@kvark
Copy link
Member Author

kvark commented Dec 2, 2021

Published in wgpu-hal-0.11.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant