hal/gles: force unbind samplers #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
added
the
PR: needs back-porting
|
|
|
Published in wgpu-hal-0.11.5 |
kvark
removed
the
PR: needs back-porting
kvark
added a commit
that referenced
this pull request
Dec 2, 2021
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Add countLeadingZeros * [glsl-out] Bake countLeadingZeros * [hlsl-out] Bake countLeadingZeros * [hlsl-out] Update Baked expressions * Remove unnecessary bake for sints * [glsl-out] CountLeadingZeros without findMSB * Don't check negatives when uint * Perform the type conv after mix * use log2 * fix clippy lints --------- Co-authored-by: teoxoy <28601907+teoxoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Discovered in vange-rs
Description
It turns out that we can't just leave the sampler object in place upon changing a texture binding. The sampler has to be compatible with the texture, or GL screams in pain, even if we don't actually sample anything.
I.e. for UINT textures, the sampler can't be linear.
Testing
Tested on vange-rs