Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal/vk: fix support for vk-1.0 and refactor the adapter code #2228

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 29, 2021

Connections
Investigating #2215

Description
Previously, we were considering the instance version and extensions for checking KhrStorageBufferStorageClassFn, but it's a device extension... Effectively means we couldn't run on VkInstance 1.0 at all.

This PR raises MSRV to 1.53 because of Option::insert().

Testing
Tested on examples locally.

@kvark kvark merged commit 57b28cb into gfx-rs:master Nov 29, 2021
@kvark kvark deleted the vk-init branch November 29, 2021 17:09
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Nov 29, 2021
@kvark
Copy link
Member Author

kvark commented Dec 2, 2021

Published in wgpu-hal-0.11.5

@kvark kvark removed the PR: needs back-porting PR with a fix that needs to land on crates label Dec 2, 2021
@parasyte
Copy link
Contributor

parasyte commented Dec 2, 2021

Heads up! I don't know if you have a minimum supported Rust version policy (I couldn't find one) but wgpu-hal 0.11.5 broke my CI because this PR uses Option::insert which was stabilized in Rust 1.53.0. (My CI was building with Rust 1.52.0, which was our MSRV).

@kvark
Copy link
Member Author

kvark commented Dec 2, 2021

Rrright, sorry about that! Are you fine updating MSRV to 1.53, or is it a showstopper? This version is close to 6 month old.

@parasyte
Copy link
Contributor

parasyte commented Dec 3, 2021

I’m good with just updating the compiler on my end for CI.

It’s a bit concerning though that this changes the policy of versions I released some months ago, too. That’s why I gave a heads up. We should be careful about making these kinds of changes in minor releases.

@kvark
Copy link
Member Author

kvark commented Dec 3, 2021

Interesting idea - to only change MSRV in breaking versions. Thanks for the hint, I'll try to stick with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants