hal/vk: fix adapter vulkan version check when requesting 1.2 capabilities #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published in wgpu-hal-0.11.5 |
kvark
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#2215 (unlikely fixes it just yet)
Description
We were using the adapter version in order to form a capability request that would tell us... the adapter version, among other things. This means, we were never requesting Vulkan-1.2 capabilities.
This fix should affect our exposed resource limits on Vulkan (cc @cwfitzgerald )
Also has a commit to follow-up to #1898
Testing
If @NiklasEi could give it a shot, that would be wonderful!