Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error scopes API #2299

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Error scopes API #2299

merged 1 commit into from
Dec 17, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Dec 17, 2021

Connections
Closes #1735

Description
Adds an ability to capture errors asynchronously using scopes.
Honestly, I find it hard to imagine this useful...

Testing
Locally tested on both native and the web

@kvark kvark requested a review from grovesNL December 17, 2021 02:40
grovesNL
grovesNL approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great! 👍

run-wasm-example.sh Show resolved Hide resolved
@kvark kvark enabled auto-merge (squash) December 17, 2021 04:30
@kvark kvark merged commit ec1d022 into gfx-rs:master Dec 17, 2021
@kvark kvark deleted the error-scopes branch December 17, 2021 04:58
cwfitzgerald pushed a commit that referenced this pull request Oct 25, 2023
@FL33TW00D
[wgsl] Use alias instead of type for type aliases (#2299)
7c00548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grovesNL grovesNL grovesNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement error scopes
2 participants
@kvark @grovesNL