Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasm examples failing to compile #2524

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix wasm examples failing to compile #2524

merged 2 commits into from
Mar 6, 2022

Commits on Mar 5, 2022

  1. Fix wasm examples failing to compile 

    They were broken by 476b6a1, because apparently enabling a feature in any package enables it for the whole workspace, and the wasm examples fail to compile with vulkan enabled.

It wasn't failing in CI because CI specifies `-p wgpu`, which seems to stop `wgpu-info`'s enabling of features having an effect.
    @Liamolucko
    Liamolucko committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    7f51466 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. #[cfg] away the contents of wgpu-info when compiling for wasm

    @Liamolucko
    Liamolucko committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    e4ac0f7 View commit details
    Browse the repository at this point in the history