Bind group deduplication #2623
Merged
Bind group deduplication #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
dedupe-bind-groups
branch
from
67c8d92
to
ef9dbea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
One component of BVE-Reborn/rend3#350
Description
This adds immediate bind group deduplication and makes pipeline deduplication immediate. This happens before the commands are even recorded to get them as early as possible. It intentionally goes out of its way to not deduplicate bind group calls with dynamic offsets.
I haven't done any other kinds of bindings because I don't know how much they show up as performance issues in practice. Bind groups are expensive enough that deduplicating them is easy enough.
Testing
Test suite