Bump wasm-bindgen to 0.2.81 #2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bump the js-sys, web-sys, and wasm-bindgen-futures crates to their latest versions.
cwfitzgerald
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
LGTM, can you update the https://github.com/gfx-rs/wgpu/wiki/Running-on-the-Web-with-WebGPU-and-WebGL page with the new wasm-bindgen version?
|
Got CI issues |
|
Sorry, my bad. I didn't checked the |
|
Closed by #2813, thank you for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump the js-sys, web-sys, and wasm-bindgen-futures crates to
their latest versions.
Connections
Not that I'm aware of.
Description
Some
web-sysfeatures were removed/renamed in rustwasm/wasm-bindgen#2906. Resolve them case-by-case - Some features were unused inwgpu, so I removed them. Some features needed to be renamed to matchwasm-bindgen.Testing
Checked that
cargo checkruns successfully after this change. Didn't run further tests.