Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence clippy::let_unit_value false positives on objc::msg_send calls. #2924

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented Jul 30, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. Not a user-visible change.

Description
The let_unit_value lint is new in Rust 1.62, and warns on all of our let () = msg_send![] calls.
rust-lang/rust-clippy#9056 might quiet it next release, though, so this may or may not be worth doing.

Testing
cargo clippy is now silent on macOS.

The `let_unit_value` lint is new in Rust 1.62.
rust-lang/rust-clippy#9056 might quiet it next
release, though, so this may or may not be worth doing.
@cwfitzgerald
Copy link
Member

Let's do it for now.

@cwfitzgerald cwfitzgerald merged commit b784eee into gfx-rs:master Jul 31, 2022
@kpreid kpreid deleted the clippy branch December 12, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants