tracking for EXTERNAL texture use #3019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
commented
Sep 12, 2022
i509VCB
force-pushed
the
vk-image-queue
branch
4 times, most recently
from
09fbc79
to
9bd347b
Compare
cwfitzgerald
requested changes
Sep 19, 2022
i509VCB
force-pushed
the
vk-image-queue
branch
from
9bd347b
to
6692386
Compare
Codecov Report
@@ Coverage Diff @@
## master #3019 +/- ##
==========================================
- Coverage 64.64% 64.53% -0.11%
==========================================
Files 82 82
Lines 39501 39608 +107
==========================================
+ Hits 25534 25560 +26
- Misses 13967 14048 +81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
i509VCB
force-pushed
the
vk-image-queue
branch
from
6692386
to
33cb495
Compare
cwfitzgerald
requested changes
Jan 18, 2023
3 tasks
|
Sorry this one got lost in the chaos, can you merge main, then we should be good to go |
viandoxdev
reviewed
Jul 25, 2023
| desc.usage.contains(crate::TextureUses::EXTERNAL), | ||
| "Texture specifies external queue family ownership but does not have TextureUse::EXTERNAL" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Aren't these two assertions wrong ? They don't match the error message or the comments above
|
As this MR is currently stale, I'm going to close it for triage purposes. Please feel-free to re-open there is renewed interest in landing these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Resolves #2948
Description
This pull request adds tracking for a new
EXTERNALtexture use. In the Vulkan hal, a new parameter fortexture_from_rawto specify the owning foreign queue of the texture is added and logic changes to transition external textures to and from the external queue.Testing
An example needs to be created to use an image that would have an EXTERNAL texture use.
I will write an example to test this. It will probably be an example using kernel mode setting (KMS).
Regarding testing on CI, I am not certain how we could approach that.