Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing device feature in mipmap example #3081

Merged
merged 4 commits into from
Oct 8, 2022

Conversation

Olaroll
Copy link
Contributor

@Olaroll Olaroll commented Oct 7, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
None

Description
I'm currently learning wgpu and noticed that the mipmap example didn't work. I added the feature indicated in the error to the appropriate place and now it works. The feature in question is WRITE_TIMESTAMP_INSIDE_PASSES.

Testing
Ran the example and it worked.

@cwfitzgerald cwfitzgerald enabled auto-merge (rebase) October 7, 2022 16:46
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff but we also need the list of features to check for when creating the query set to be extended with this feature

@Olaroll
Copy link
Contributor Author

Olaroll commented Oct 7, 2022

Not quite sure what a query set does, but hopefully that fixes it 😅

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) October 8, 2022 05:13
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Query sets qre ways of asking the GPU information (either timing or statistics) and managing the queries while they are being processed - the features involved are required for their creation.

@cwfitzgerald cwfitzgerald merged commit f57db15 into gfx-rs:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants