Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying of textures with copy-compatible formats #3528

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 24, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
Allows copying of textures with copy-compatible formats.
See https://gpuweb.github.io/gpuweb/#copy-compatible

Testing
Ideally, we'd test this via the CTS.

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Feb 24, 2023
@teoxoy teoxoy force-pushed the copy_texture_to_texture_compat branch 4 times, most recently from 77dac7b to bd57766 Compare February 24, 2023 17:31
wgpu-core/src/command/transfer.rs Outdated Show resolved Hide resolved
wgpu-hal/src/metal/command.rs Show resolved Hide resolved
@teoxoy teoxoy force-pushed the copy_texture_to_texture_compat branch from bd57766 to dc3e9ab Compare March 2, 2023 22:24
@teoxoy teoxoy force-pushed the copy_texture_to_texture_compat branch from dc3e9ab to 89d0bac Compare March 2, 2023 22:30
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G - going to merge the error message PR first than resolve conflict on the error message here

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) March 3, 2023 17:10
@cwfitzgerald cwfitzgerald merged commit 7e72f30 into gfx-rs:master Mar 3, 2023
@teoxoy teoxoy deleted the copy_texture_to_texture_compat branch March 3, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants