[dx12] Use typeless formats for textures that might be viewed as srgb or non-srgb #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
dx12-typeless-view-formats
branch
2 times, most recently
from
8a6479f
to
025af7d
Compare
cwfitzgerald
requested changes
Mar 3, 2023
… or non-srgb query `CastingFullyTypedFormatSupported` and skip typeless formats if available
teoxoy
force-pushed
the
dx12-typeless-view-formats
branch
from
025af7d
to
4507a2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
View formats initially implemented in #3237
Description
Use typeless formats for textures that might be viewed as srgb or non-srgb.
I also tried to query
CastingFullyTypedFormatSupportedand skip the typeless formats but later realized that winapi doesn't support options3.Testing
I don't have the hardware to properly test this.