Allow max_bind_groups to be missing, for now #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll revert this once gfx-rs backends are exposing the limit properly. |
Build succeeded |
parasyte
added a commit
to parasyte/wgpu
that referenced
this pull request
Nov 2, 2019
This was referenced Nov 2, 2019
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
356: Add generic ranges to buffer mapping api and make it safe. r=kvark a=lachlansneff [Rendered](https://charted.space/notes/wgpu-rs/wgpu/struct.Buffer.html) The safety issues with the current api (being able to unmap while still holding a slice to mapped data) are fixed by having `get_mapped_range` and `get_mapped_range_mut` return `BufferView` and `BufferViewMut`, which notify the buffer that those ranges are no longer being used when they're dropped. `Buffer.unmap` asserts that the list of mapped ranges is empty, therefore it is safe. Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
…'static str (gfx-rs#356) * Changed front::glsl::error::ErrorKind::Semantic to use Cow * cargo fmt * appeasing clippy * Update src/front/glsl/functions.rs Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com> * Fixed more clippy errors Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com> Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355