Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Global hubs #357

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Explicit Global hubs #357

merged 4 commits into from
Oct 25, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Oct 24, 2019

Fixes #354

@kvark kvark requested a review from grovesNL October 24, 2019 15:47
@@ -17,7 +17,7 @@ crate-type = ["lib", "cdylib", "staticlib"]

[features]
default = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to move to local instead of remote? I could see usefulness in being able to opt out of remote-specific concepts if we expose more in wgpu-native (even though we don't have much currently). Either way it might still be good to list local as a default feature to make it easier for people to build wgpu-native directly (thinking of https://nest.pijul.com/porky11/wgpu for example)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer is - remote used to add some extra capabilities, like the Serde derives. As I was trying to integrate it into Gecko, I realized that using Gecko's IPC is the only way. That means Serde is no longer useful, or at least, doesn't get associated with "remote" feature.

At the same time, this PR gets rid of the static GLOBAL in general case. So it's "local" that adds features now: it exposes C entry points and declares a lazy static used in them.

@kvark
Copy link
Member Author

kvark commented Oct 25, 2019

Actually, I'm hesitating to make local default :/ Reason being: default features have a tendency to be force-enabled. For example, if there is any wrapper/helper around wgpu-native, we'd need to make sure that it's using "default-features = false".

The inconvenience will not affect wgpu-rs users. It's only going to affect users of wgpu-native from other languages, like the one you linked to. It's a one time fix for them without any unexpected problems down the road.

Saying that, we can always turn this back to default - it's a 2 line fix.
bors r=grovesNL

bors bot added a commit that referenced this pull request Oct 25, 2019
357: Explicit Global hubs r=grovesNL a=kvark

Fixes #354

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 25, 2019

Build succeeded

@bors bors bot merged commit 5099754 into gfx-rs:master Oct 25, 2019
@kvark kvark deleted the global branch October 25, 2019 03:07
kvark added a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
357: Render bundle support, use in msaa-line example r=cwfitzgerald a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote multi-process support
2 participants