Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence vulkan validation error (#3095) #3627

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

seabassjh
Copy link
Contributor

@seabassjh seabassjh commented Mar 31, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Closes #3095

Description
This solves #3095

Testing
Tested the reproduceable project in #3095 before and after the change, and observed the desired result (no validation error)

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aloucks
Copy link
Contributor

aloucks commented May 26, 2023

Pretty sure this was a legit validation warning and should not be silenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan validation error minImageExtent same as maxImageExtent
3 participants