Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: note feature req. for Depth32FloatStencil8 #3734

Merged
merged 4 commits into from
May 3, 2023
Merged

docs: note feature req. for Depth32FloatStencil8 #3734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3963fb4
docs: note feature req. for `Depth32FloatStencil8`
ErichDonGubler Apr 27, 2023
9066fdf
docs: style `spirv-passthrough`/`naga` refs. consistently
ErichDonGubler Apr 27, 2023
cff9fe8
chore(wgpu-core): remove period from `CreateTextureError::MissingFeat…
ErichDonGubler Apr 27, 2023
05527d2
Merge branch 'trunk' into depth32float-stencil8-docs
cwfitzgerald May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ Bottom level categories:

## Unreleased

### Documentation

#### General

- Document feature requirements for `DEPTH32FLOAT_STENCIL8` by @ErichDonGubler in [#3734](https://github.com/gfx-rs/wgpu/pull/3734).

### Bug Fixes

#### General
Expand Down
2 changes: 1 addition & 1 deletion wgpu-core/src/resource.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ pub enum CreateTextureError {
InvalidSampleCount(u32, wgt::TextureFormat),
#[error("Multisampled textures must have RENDER_ATTACHMENT usage")]
MultisampledNotRenderAttachment,
#[error("Texture format {0:?} can't be used due to missing features.")]
#[error("Texture format {0:?} can't be used due to missing features")]
MissingFeatures(wgt::TextureFormat, #[source] MissingFeatures),
#[error(transparent)]
MissingDownlevelFlags(#[from] MissingDownlevelFlags),
Expand Down
6 changes: 4 additions & 2 deletions wgpu-types/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ bitflags::bitflags! {

/// Allows shaders to acquire the FP16 ability
///
/// Note: this is not supported in naga yet，only through spir-v passthrough right now.
/// Note: this is not supported in `naga` yet，only through `spirv-passthrough` right now.
///
/// Supported Platforms:
/// - Vulkan
Expand Down Expand Up @@ -728,7 +728,7 @@ bitflags::bitflags! {
///
/// This is a native only feature.
const SHADER_F64 = 1 << 59;
/// Allows shaders to use i16. Not currently supported in naga, only available through `spirv-passthrough`.
/// Allows shaders to use i16. Not currently supported in `naga`, only available through `spirv-passthrough`.
///
/// Supported platforms:
/// - Vulkan
Expand Down Expand Up @@ -2025,6 +2025,8 @@ pub enum TextureFormat {
/// Special depth format with 32 bit floating point depth.
Depth32Float,
/// Special depth/stencil format with 32 bit floating point depth and 8 bits integer stencil.
///
/// [`Features::DEPTH32FLOAT_STENCIL8`] must be enabled to use this texture format.
Depth32FloatStencil8,

// Compressed textures usable with `TEXTURE_COMPRESSION_BC` feature.
Expand Down