Fix order of arguments to glPolygonOffset. #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
While investigating a Z-fighting issue shown in komadori/bevy_mod_outline#19 which is apparently specific to WebGL, I noticed that wgpu-hal's GL ES back-end appears to be passing the wrong arguments to glPolygonOffset. However, this bug is ultimately largely incidental to that issue.
Description
glPolygonOffset takes two arguments,
factorandunits. The terminology used is slightly different to wgpu, but I believefactor("specifies a scale factor") should correspond toslope_scaleandunits("create a constant depth offset") toconstant. However, wgpu passes these arguments in the reverse order and this PR corrects that.Testing
In practice, both the
slope_scaleandconstantare often set to around 1 so wgpu swapping them would go unnoticed. I don't have a meaningful test case for this and am judging it correct by inspection of the code and OpenGL documentation.