Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deno #3808

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Update deno #3808

merged 5 commits into from
Jun 6, 2023

Conversation

crowlKats
Copy link
Collaborator

Updated #2170.

Had to bump minimum required rust version as deno requires 1.65

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@crowlKats
Copy link
Collaborator Author

@jimblandy any clue whats going on with CI? cant replicate these errors locally

@cwfitzgerald
Copy link
Member

note: the aarch64-apple-darwin target may not be installed

This is the error that happens when the rustup target is not properly installed.

We very explicitly install 1.64 in https://github.com/gfx-rs/wgpu/blob/trunk/.github/workflows/ci.yml#L99, so updating the toolchain file makes it download 1.65 just-in-time, but not including the proper toolchain.

@crowlKats crowlKats merged commit 0ece5e6 into gfx-rs:trunk Jun 6, 2023
@crowlKats crowlKats deleted the update_deno branch June 6, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants