Make RequestAdapterOptions.power_preference optional #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
reviewed
Jul 5, 2023
|
Could you drop the Cargo.lock change from the patch, that looks unrelated and unnecessary. |
Aaron1011
force-pushed
the
opt-power-preference
branch
from
3f208f5
to
c4d68ef
Compare
cwfitzgerald
requested changes
Jul 7, 2023
The WebGPU docs state that the `powerPreference` field is optional - it can be set to `undefined`, which provides no hint. Currently, wgpu only allows using an explicit LowPower or HighPerformance hint. This can cause a secondary backend to be chosen over a primary backend when the secondary backend is the only one matching the power preference - with no way to ensure that a primary backend takes priority. This commit changes `RequestAdapterOptions.power_preference` to store an `Option<PowerPreference>`, and removes the `Default` impl from `PowerPreference`. Under WebGPU, we leave `GPURequestAdapterOptions.powerPreference` when our value is `None`. Under native, we skip the backend preference logic.
Aaron1011
force-pushed
the
opt-power-preference
branch
from
c4d68ef
to
2243859
Compare
|
@cwfitzgerald @nical I've pushed a new commit addressing your comments. |
cwfitzgerald
requested changes
Jul 10, 2023
|
FTR: 👀Firefox is actually interested in tracking this PR at bug 1841840. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
None
Description
The WebGPU docs state that the
powerPreferencefield is optional - it can be set toundefined, which provides no hint.Currently, wgpu only allows using an explicit LowPower or HighPerformance hint. This can cause a secondary backend to be chosen over a primary backend when the secondary backend is the only one matching the power preference - with no way to ensure that a primary backend takes priority.
This PR changes adds a
PowerPreference::Nonevariant. Under WebGPU, we leaveGPURequestAdapterOptions.powerPreferenceunset when we havePowerPreference::None. Under native, we pick the lowest-indexed adapter out of [discrete, integrated, other].Testing
On a system with an OpenGL adapter and a Vulkan adapter, run
example/hello. The Vulkan adapter should be chosen, even if the Vulkan adapter is high-performance and the OpenGL adapter is low-power.