Port to d3d12 0.7 with ownership #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the WeakPtr usage with ComPtr which is no longer Copy. This means we need to do a bunch of clone()s and take some things as references.
jrmuizel
force-pushed
the
d3d12-ownership
branch
from
1175245
to
a76d17c
Compare
ErichDonGubler
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Noting that I have no merge privileges, I've reviewed these changes in some depth for the last couple of days. I feel satisfied that no meaningful changes have been made WRT the actual Release of COM objects where intended, which IMO is the major concern here. This does extend the lifetime of some objects based on our testing of issues that Firefox users have encountered, but in a way that's needed to avoid issues. We've already tested consuming this change in Firefox, and it fixes some important bugs, a few CTS test cases among them.
3 tasks
ErichDonGubler
added
type: bug
jimblandy
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the WeakPtr usage with ComPtr which is no longer Copy. This means we need to do a bunch of clone()s and take some things as references.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.