WIP: refactor(hal): migrate from cstr_from_bytes_until_nul to CStr::from_bytes_until_nul
#3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
cstr-from_bytes_until_nul
branch
2 times, most recently
from
4dc8812
to
0513b7a
Compare
…::from_bytes_until_nul` Not mergeable until MSRV is Rust 1.69.
ErichDonGubler
force-pushed
the
cstr-from_bytes_until_nul
branch
from
0513b7a
to
6671301
Compare
|
As firefox's MSRV hasn't been bumped in a while, and this is a very minor change, I'm going to close this for triage purposes. If firefox ever is bumped, we can re-open this, as the changes otherwise look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not mergeable until:
type c_char = i8.Checklist
cargo clippy.Runcargo clippy --target wasm32-unknown-unknownif applicable.Add change to CHANGELOG.md. See simple instructions inside file.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
N/A
Description
Describe what problem this is solving, and how it's solved.
See removed code commentary about API we're migrating to.
Testing
Explain how this change is tested.
If CI passes, then I have enough confidence to ship this.