Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit texture store bound checks since they are no-ops if out of bounds on all APIs #3975

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Omit texture store bound checks since they are no-ops if out of bounds on all APIs #3975

merged 2 commits into from
Jul 25, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 25, 2023

resolves #3894

@teoxoy teoxoy changed the title Omit texture store bound checks since they are no-ops if out of bounds on all APIs… Omit texture store bound checks since they are no-ops if out of bounds on all APIs Jul 25, 2023
ErichDonGubler
ErichDonGubler approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teoxoy teoxoy merged commit adc43b5 into gfx-rs:trunk Jul 25, 2023
20 checks passed
@teoxoy teoxoy deleted the no-oob-check-texture-write branch July 25, 2023 15:04
@teoxoy teoxoy mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Texture writes don't need bounds checks on Vulkan, Metal, or Direct3D
2 participants
@teoxoy @ErichDonGubler