[WebGPU] validate polygon mode #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Pushed up my nitpicks as fixup! commits, so you can autosquash. If you disagree, feel free to drop the relevant commits instead. 🙂
Non-blocking, but: Is there a way we can meaningfully test for this? Not sure what appetite we have for backend-specific tests, but it'd be nice to not regress later.
ErichDonGubler
force-pushed
the
webgpu-validate-polygon-mode
branch
2 times, most recently
from
76dd103
to
16ff4df
Compare
cwfitzgerald
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Going to respectfully veto @ErichDonGubler's changes, and this is good to go once they're reverted.
teoxoy
force-pushed
the
webgpu-validate-polygon-mode
branch
from
16ff4df
to
a7b5d98
Compare
🤔 Huh, I didn't expect these to be controversial. Why's that? |
|
I responded individually in each subthread :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
fixes #4194