Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp support to OpenGL #4267

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Add timestamp support to OpenGL #4267

merged 4 commits into from
Oct 24, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Oct 19, 2023

This adds support for timestamp to the OpenGL backend using timer queries and query buffer objects.

This depends on an unreleased version of glow for the query_counter and get_query_parameter_u64_with_offset functions.

@Zoxc Zoxc requested a review from a team as a code owner October 19, 2023 01:17
@Zoxc Zoxc force-pushed the gl-timestamps branch 2 times, most recently from c0ba6bb to 0320302 Compare October 19, 2023 01:43
@cwfitzgerald
Copy link
Member

cwfitzgerald commented Oct 21, 2023 •
edited
Loading

Want to land #4270 first so this gets test coverage. Should be able to do this tomorrow.

cwfitzgerald
cwfitzgerald requested changes Oct 23, 2023
View reviewed changes
wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/queue.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think we need one more iteration and we should be good

wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G after comment

wgpu-types/src/lib.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 3bdad8b into gfx-rs:trunk Oct 24, 2023
23 checks passed
@Zoxc Zoxc deleted the gl-timestamps branch October 24, 2023 01:31
@Zoxc Zoxc mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zoxc @cwfitzgerald