Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga msl-out] Emit and init struct member padding always #4701

Merged
merged 4 commits into from
Nov 22, 2023
Merged

[naga msl-out] Emit and init struct member padding always #4701

merged 4 commits into from
Nov 22, 2023

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 16, 2023 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Resolves #4522.

Description
Describe what problem this is solving, and how it's solved.

Previously, implicit padding members of structs were suppressed from structure definitions in Metal output if they had a binding specified for them (i.e., @location(0)). This padding is, however, is necessary for correct access of member fields passed into shaders by uniform and storage buffers. Unconditionally emit padding members for structs.

Testing
Explain how this change is tested.

I've added a new struct-layout test to naga's snapshots test suite to exercise the adjustments to vertex shader coercion of varyings structures (i.e., "

@ErichDonGubler ErichDonGubler changed the title fix(msl-out): coerce packed vec3s to unpacked always fix(msl-out): see what ignoring member.binding does for padding in MSL Nov 16, 2023
@ErichDonGubler ErichDonGubler changed the title fix(msl-out): see what ignoring member.binding does for padding in MSL See what ignoring member.binding does for padding in MSL Nov 16, 2023
@teoxoy

This comment was marked as outdated.

Sign in to view
@teoxoy teoxoy closed this Nov 16, 2023
@teoxoy teoxoy deleted the msl-should-pack-bound-fields branch November 16, 2023 23:14
@ErichDonGubler ErichDonGubler restored the msl-should-pack-bound-fields branch November 20, 2023 20:53
@ErichDonGubler
Copy link
Member Author

Reopening this, as this fix is actually the right direction for #4522 (which has been reopened, also).

@ErichDonGubler ErichDonGubler self-assigned this Nov 20, 2023
@ErichDonGubler ErichDonGubler changed the title See what ignoring member.binding does for padding in MSL Ignore member.binding for structs in MSL Nov 20, 2023
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
amend! WIP: fix(msl-out): don't check member.binding in `write_type…
e70e4ba 
…_defs`, `should_pack_struct_member`

fix(msl-out): emit and init `struct` member padding always

Resolves
[`gfx-rs/wgpu`#4701](#4701).
@ErichDonGubler ErichDonGubler changed the title Ignore member.binding for structs in MSL [naga msl-out] Emit and init struct member padding always Nov 21, 2023
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@ErichDonGubler ErichDonGubler marked this pull request as ready for review November 21, 2023 20:14
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 21, 2023 20:14
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
5452b20 
Resolves
[`gfx-rs/wgpu`#4701](#4701).
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
d6dfcc6 
Resolves
[`gfx-rs/wgpu`#4701](#4701).
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
fc12129 
Resolves
[`gfx-rs/wgpu`#4701](#4701).
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
amend! fix(msl-out): emit and init struct member padding always
2889a1a 
fix(msl-out): emit and init `struct` member padding always

Previously, implicit padding members of `struct`s were suppressed from
structure definitions in Metal output if they had a binding specified
for them (i.e., `@location(0)`). This padding is, however, is necessary
for correct access of member fields passed into shaders by uniform and
storage buffers. Unconditionally emit padding members for `struct`s.

Resolves
[`gfx-rs/wgpu`#4701](#4701).
ErichDonGubler added a commit that referenced this pull request Nov 21, 2023
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
859ef22 
Previously, implicit padding members of `struct`s were suppressed from
structure definitions in Metal output if they had a binding specified
for them (i.e., `@location(0)`). This padding is, however, is necessary
for correct access of member fields passed into shaders by uniform and
storage buffers. Unconditionally emit padding members for `struct`s.

Resolves
[`gfx-rs/wgpu`#4701](#4701).
teoxoy
teoxoy approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

naga/CHANGELOG.md Outdated Show resolved Hide resolved
naga/tests/out/msl/quad.msl Show resolved Hide resolved
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
5f2ebf0 
Previously, implicit padding members of `struct`s were suppressed from
structure definitions in Metal output if they had a binding specified
for them (i.e., `@location(0)`). This padding is, however, is necessary
for correct access of member fields passed into shaders by uniform and
storage buffers. Unconditionally emit padding members for `struct`s.

Resolves
[`gfx-rs/wgpu`#4701](#4701).
@ErichDonGubler
chore(msl-out): should_pack_struct_member: remove unnecessary align…
bfc77fe 
…ment check for `vec3`s
@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) November 22, 2023 00:07
@ErichDonGubler ErichDonGubler merged commit 1cf0fe8 into trunk Nov 22, 2023
52 checks passed
@ErichDonGubler ErichDonGubler deleted the msl-should-pack-bound-fields branch November 22, 2023 10:54
ErichDonGubler added a commit that referenced this pull request Nov 22, 2023
@ErichDonGubler
fix(msl-out): emit and init struct member padding always
611da6d 
Previously, implicit padding members of `struct`s were suppressed from
structure definitions in Metal output if they had a binding specified
for them (i.e., `@location(0)`). This padding is, however, is necessary
for correct access of member fields passed into shaders by uniform and
storage buffers. Unconditionally emit padding members for `struct`s.

Resolves
[`gfx-rs/wgpu`#4701](#4701).
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Nov 22, 2023
@kpreid
wgpu: Remove Metal uniform padding workaround.
5c974d1 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19 (not yet released as of this writing).
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 5, 2023
@nical
Bug 1868143 - Update wgpu to revision 767ac03245ee937d3dc552edc13fe…
0a15b03 
…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler

# Changelog

 * #4708 Fix max_vertex_buffers validation
   By nical in gfx-rs/wgpu#4708
 * #4729 Remove expected failure on AMD/DX12 from msaa example
   By teoxoy in gfx-rs/wgpu#4729
 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals.
   By jimblandy in gfx-rs/wgpu#4711
 * #4736 Bump serde from 1.0.192 to 1.0.193
   By dependabot[bot] in gfx-rs/wgpu#4736
 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width.
   By jimblandy in gfx-rs/wgpu#4735
 * #4741 [naga] Fix type error in test.
   By jimblandy in gfx-rs/wgpu#4741
 * #4742 [naga]: Make snapshot tests include paths in errors.
   By jimblandy in gfx-rs/wgpu#4742
 * #4723 Test And Normalize Vertex Behavior on All Backends
   By cwfitzgerald in gfx-rs/wgpu#4723
 * #4746 Skip Flaky Test
   By cwfitzgerald in gfx-rs/wgpu#4746
 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings
   By bradwerth in gfx-rs/wgpu#4744
 * #4745 [naga wgsl-in] Test hex float suffix handling corner case.
   By jimblandy in gfx-rs/wgpu#4745
 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress>
   By nical in gfx-rs/wgpu#4737
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations.
   By jimblandy in gfx-rs/wgpu#4733
 * #4734 [naga] Make compaction preserve named types, even if unused.
   By jimblandy in gfx-rs/wgpu#4734
 * #4752 Logging cleanups in device/global.rs
   By nical in gfx-rs/wgpu#4752
 * #4753 Fix Mac Event Loop
   By cwfitzgerald in gfx-rs/wgpu#4753
 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER
   By i509VCB in gfx-rs/wgpu#4754
 * #4748 Allow Tests to Expect Certain Panic or Validation Messages
   By cwfitzgerald in gfx-rs/wgpu#4748
 * #4756 Move to A Single Example Executable
   By cwfitzgerald in gfx-rs/wgpu#4756
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature.
   By jimblandy in gfx-rs/wgpu#4761
 * #4769 Conditionally lift API logging from trace to info level
   By nical in gfx-rs/wgpu#4769
 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug
   By nical in gfx-rs/wgpu#4771
 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER`
   By teoxoy in gfx-rs/wgpu#4760
 * #4772 Downgrade resource lifetime management log level to trace.
   By nical in gfx-rs/wgpu#4772
 * #4765 Revamp Examples to Match Website
   By cwfitzgerald in gfx-rs/wgpu#4765
 * #4774 Update examples readme files
   By roffs in gfx-rs/wgpu#4774
 * #4781 remove_abandoned fix
   By gents83 in gfx-rs/wgpu#4781
 * #4777 Bump web-sys to 0.3.65
   By torokati44 in gfx-rs/wgpu#4777
 * #4780 Fixes for Skybox and All Examples
   By cwfitzgerald in gfx-rs/wgpu#4780
 * #4782 Remove resources ONLY when needed inside wgpu and not in user land
   By gents83 in gfx-rs/wgpu#4782
 * #4786 Don't keep a strong ref in storage for destroyed resources
   By gents83 in gfx-rs/wgpu#4786
 * #4795 Fix Arcanization changelog
   By a1phyr in gfx-rs/wgpu#4795
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4573 Support nv12 texture format
   By xiaopengli89 in gfx-rs/wgpu#4573
 * #4789 Bump js-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4789
 * #4784 Bump winit from 0.29.3 to 0.29.4
   By dependabot[bot] in gfx-rs/wgpu#4784
 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0
   By dependabot[bot] in gfx-rs/wgpu#4798
 * #4800 Bump web-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4800
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39
   By dependabot[bot] in gfx-rs/wgpu#4799
 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning)
   By Wumpf in gfx-rs/wgpu#4796
 * #4804 Add space to a comment inside make_spirv_raw
   By ComfyFluffy in gfx-rs/wgpu#4804
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message.
   By jimblandy in gfx-rs/wgpu#4805
 * #4801 update deno
   By crowlKats in gfx-rs/wgpu#4801
 * #4806 Fixes and changes to the documentation for increasing clarity
   By Blatko1 in gfx-rs/wgpu#4806
 * #4809 [naga wgsl-in] Use a better span for errors in constructors.
   By jimblandy in gfx-rs/wgpu#4809
 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages.
   By jimblandy in gfx-rs/wgpu#4808
 * #4822 Fix expected error message
   By teoxoy in gfx-rs/wgpu#4822
 * #4759 Add feature float32-filterable
   By almarklein in gfx-rs/wgpu#4759
 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3
   By dependabot[bot] in gfx-rs/wgpu#4813

Differential Revision: https://phabricator.services.mozilla.com/D195438
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Dec 5, 2023
@nical
Bug 1868143 - Update wgpu to revision 767ac03245ee937d3dc552edc13fe…
bd02031 
…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler

# Changelog

 * #4708 Fix max_vertex_buffers validation
   By nical in gfx-rs/wgpu#4708
 * #4729 Remove expected failure on AMD/DX12 from msaa example
   By teoxoy in gfx-rs/wgpu#4729
 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals.
   By jimblandy in gfx-rs/wgpu#4711
 * #4736 Bump serde from 1.0.192 to 1.0.193
   By dependabot[bot] in gfx-rs/wgpu#4736
 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width.
   By jimblandy in gfx-rs/wgpu#4735
 * #4741 [naga] Fix type error in test.
   By jimblandy in gfx-rs/wgpu#4741
 * #4742 [naga]: Make snapshot tests include paths in errors.
   By jimblandy in gfx-rs/wgpu#4742
 * #4723 Test And Normalize Vertex Behavior on All Backends
   By cwfitzgerald in gfx-rs/wgpu#4723
 * #4746 Skip Flaky Test
   By cwfitzgerald in gfx-rs/wgpu#4746
 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings
   By bradwerth in gfx-rs/wgpu#4744
 * #4745 [naga wgsl-in] Test hex float suffix handling corner case.
   By jimblandy in gfx-rs/wgpu#4745
 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress>
   By nical in gfx-rs/wgpu#4737
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations.
   By jimblandy in gfx-rs/wgpu#4733
 * #4734 [naga] Make compaction preserve named types, even if unused.
   By jimblandy in gfx-rs/wgpu#4734
 * #4752 Logging cleanups in device/global.rs
   By nical in gfx-rs/wgpu#4752
 * #4753 Fix Mac Event Loop
   By cwfitzgerald in gfx-rs/wgpu#4753
 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER
   By i509VCB in gfx-rs/wgpu#4754
 * #4748 Allow Tests to Expect Certain Panic or Validation Messages
   By cwfitzgerald in gfx-rs/wgpu#4748
 * #4756 Move to A Single Example Executable
   By cwfitzgerald in gfx-rs/wgpu#4756
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature.
   By jimblandy in gfx-rs/wgpu#4761
 * #4769 Conditionally lift API logging from trace to info level
   By nical in gfx-rs/wgpu#4769
 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug
   By nical in gfx-rs/wgpu#4771
 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER`
   By teoxoy in gfx-rs/wgpu#4760
 * #4772 Downgrade resource lifetime management log level to trace.
   By nical in gfx-rs/wgpu#4772
 * #4765 Revamp Examples to Match Website
   By cwfitzgerald in gfx-rs/wgpu#4765
 * #4774 Update examples readme files
   By roffs in gfx-rs/wgpu#4774
 * #4781 remove_abandoned fix
   By gents83 in gfx-rs/wgpu#4781
 * #4777 Bump web-sys to 0.3.65
   By torokati44 in gfx-rs/wgpu#4777
 * #4780 Fixes for Skybox and All Examples
   By cwfitzgerald in gfx-rs/wgpu#4780
 * #4782 Remove resources ONLY when needed inside wgpu and not in user land
   By gents83 in gfx-rs/wgpu#4782
 * #4786 Don't keep a strong ref in storage for destroyed resources
   By gents83 in gfx-rs/wgpu#4786
 * #4795 Fix Arcanization changelog
   By a1phyr in gfx-rs/wgpu#4795
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4573 Support nv12 texture format
   By xiaopengli89 in gfx-rs/wgpu#4573
 * #4789 Bump js-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4789
 * #4784 Bump winit from 0.29.3 to 0.29.4
   By dependabot[bot] in gfx-rs/wgpu#4784
 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0
   By dependabot[bot] in gfx-rs/wgpu#4798
 * #4800 Bump web-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4800
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39
   By dependabot[bot] in gfx-rs/wgpu#4799
 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning)
   By Wumpf in gfx-rs/wgpu#4796
 * #4804 Add space to a comment inside make_spirv_raw
   By ComfyFluffy in gfx-rs/wgpu#4804
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message.
   By jimblandy in gfx-rs/wgpu#4805
 * #4801 update deno
   By crowlKats in gfx-rs/wgpu#4801
 * #4806 Fixes and changes to the documentation for increasing clarity
   By Blatko1 in gfx-rs/wgpu#4806
 * #4809 [naga wgsl-in] Use a better span for errors in constructors.
   By jimblandy in gfx-rs/wgpu#4809
 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages.
   By jimblandy in gfx-rs/wgpu#4808
 * #4822 Fix expected error message
   By teoxoy in gfx-rs/wgpu#4822
 * #4759 Add feature float32-filterable
   By almarklein in gfx-rs/wgpu#4759
 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3
   By dependabot[bot] in gfx-rs/wgpu#4813

Differential Revision: https://phabricator.services.mozilla.com/D195438
@ErichDonGubler ErichDonGubler added api: metal Issues with Metal platform: macos Issues with integration with macos area: naga back-end Outputs of naga shader conversion naga Shader Translator labels Dec 5, 2023
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 7, 2023
@marco-c
Bug 1868143 - Update wgpu to revision 767ac03245ee937d3dc552edc13fe…
718ed41 
…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler

# Changelog

 * #4708 Fix max_vertex_buffers validation
   By nical in gfx-rs/wgpu#4708
 * #4729 Remove expected failure on AMD/DX12 from msaa example
   By teoxoy in gfx-rs/wgpu#4729
 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals.
   By jimblandy in gfx-rs/wgpu#4711
 * #4736 Bump serde from 1.0.192 to 1.0.193
   By dependabot[bot] in gfx-rs/wgpu#4736
 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width.
   By jimblandy in gfx-rs/wgpu#4735
 * #4741 [naga] Fix type error in test.
   By jimblandy in gfx-rs/wgpu#4741
 * #4742 [naga]: Make snapshot tests include paths in errors.
   By jimblandy in gfx-rs/wgpu#4742
 * #4723 Test And Normalize Vertex Behavior on All Backends
   By cwfitzgerald in gfx-rs/wgpu#4723
 * #4746 Skip Flaky Test
   By cwfitzgerald in gfx-rs/wgpu#4746
 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings
   By bradwerth in gfx-rs/wgpu#4744
 * #4745 [naga wgsl-in] Test hex float suffix handling corner case.
   By jimblandy in gfx-rs/wgpu#4745
 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress>
   By nical in gfx-rs/wgpu#4737
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations.
   By jimblandy in gfx-rs/wgpu#4733
 * #4734 [naga] Make compaction preserve named types, even if unused.
   By jimblandy in gfx-rs/wgpu#4734
 * #4752 Logging cleanups in device/global.rs
   By nical in gfx-rs/wgpu#4752
 * #4753 Fix Mac Event Loop
   By cwfitzgerald in gfx-rs/wgpu#4753
 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER
   By i509VCB in gfx-rs/wgpu#4754
 * #4748 Allow Tests to Expect Certain Panic or Validation Messages
   By cwfitzgerald in gfx-rs/wgpu#4748
 * #4756 Move to A Single Example Executable
   By cwfitzgerald in gfx-rs/wgpu#4756
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature.
   By jimblandy in gfx-rs/wgpu#4761
 * #4769 Conditionally lift API logging from trace to info level
   By nical in gfx-rs/wgpu#4769
 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug
   By nical in gfx-rs/wgpu#4771
 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER`
   By teoxoy in gfx-rs/wgpu#4760
 * #4772 Downgrade resource lifetime management log level to trace.
   By nical in gfx-rs/wgpu#4772
 * #4765 Revamp Examples to Match Website
   By cwfitzgerald in gfx-rs/wgpu#4765
 * #4774 Update examples readme files
   By roffs in gfx-rs/wgpu#4774
 * #4781 remove_abandoned fix
   By gents83 in gfx-rs/wgpu#4781
 * #4777 Bump web-sys to 0.3.65
   By torokati44 in gfx-rs/wgpu#4777
 * #4780 Fixes for Skybox and All Examples
   By cwfitzgerald in gfx-rs/wgpu#4780
 * #4782 Remove resources ONLY when needed inside wgpu and not in user land
   By gents83 in gfx-rs/wgpu#4782
 * #4786 Don't keep a strong ref in storage for destroyed resources
   By gents83 in gfx-rs/wgpu#4786
 * #4795 Fix Arcanization changelog
   By a1phyr in gfx-rs/wgpu#4795
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4573 Support nv12 texture format
   By xiaopengli89 in gfx-rs/wgpu#4573
 * #4789 Bump js-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4789
 * #4784 Bump winit from 0.29.3 to 0.29.4
   By dependabot[bot] in gfx-rs/wgpu#4784
 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0
   By dependabot[bot] in gfx-rs/wgpu#4798
 * #4800 Bump web-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4800
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39
   By dependabot[bot] in gfx-rs/wgpu#4799
 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning)
   By Wumpf in gfx-rs/wgpu#4796
 * #4804 Add space to a comment inside make_spirv_raw
   By ComfyFluffy in gfx-rs/wgpu#4804
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message.
   By jimblandy in gfx-rs/wgpu#4805
 * #4801 update deno
   By crowlKats in gfx-rs/wgpu#4801
 * #4806 Fixes and changes to the documentation for increasing clarity
   By Blatko1 in gfx-rs/wgpu#4806
 * #4809 [naga wgsl-in] Use a better span for errors in constructors.
   By jimblandy in gfx-rs/wgpu#4809
 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages.
   By jimblandy in gfx-rs/wgpu#4808
 * #4822 Fix expected error message
   By teoxoy in gfx-rs/wgpu#4822
 * #4759 Add feature float32-filterable
   By almarklein in gfx-rs/wgpu#4759
 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3
   By dependabot[bot] in gfx-rs/wgpu#4813

Differential Revision: https://phabricator.services.mozilla.com/D195438

UltraBlame original commit: 985aabb5bf419ffcc9248010353ff190c225ba61
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 7, 2023
@marco-c
Bug 1868143 - Update wgpu to revision 767ac03245ee937d3dc552edc13fe…
4825830 
…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler

# Changelog

 * #4708 Fix max_vertex_buffers validation
   By nical in gfx-rs/wgpu#4708
 * #4729 Remove expected failure on AMD/DX12 from msaa example
   By teoxoy in gfx-rs/wgpu#4729
 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals.
   By jimblandy in gfx-rs/wgpu#4711
 * #4736 Bump serde from 1.0.192 to 1.0.193
   By dependabot[bot] in gfx-rs/wgpu#4736
 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width.
   By jimblandy in gfx-rs/wgpu#4735
 * #4741 [naga] Fix type error in test.
   By jimblandy in gfx-rs/wgpu#4741
 * #4742 [naga]: Make snapshot tests include paths in errors.
   By jimblandy in gfx-rs/wgpu#4742
 * #4723 Test And Normalize Vertex Behavior on All Backends
   By cwfitzgerald in gfx-rs/wgpu#4723
 * #4746 Skip Flaky Test
   By cwfitzgerald in gfx-rs/wgpu#4746
 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings
   By bradwerth in gfx-rs/wgpu#4744
 * #4745 [naga wgsl-in] Test hex float suffix handling corner case.
   By jimblandy in gfx-rs/wgpu#4745
 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress>
   By nical in gfx-rs/wgpu#4737
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations.
   By jimblandy in gfx-rs/wgpu#4733
 * #4734 [naga] Make compaction preserve named types, even if unused.
   By jimblandy in gfx-rs/wgpu#4734
 * #4752 Logging cleanups in device/global.rs
   By nical in gfx-rs/wgpu#4752
 * #4753 Fix Mac Event Loop
   By cwfitzgerald in gfx-rs/wgpu#4753
 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER
   By i509VCB in gfx-rs/wgpu#4754
 * #4748 Allow Tests to Expect Certain Panic or Validation Messages
   By cwfitzgerald in gfx-rs/wgpu#4748
 * #4756 Move to A Single Example Executable
   By cwfitzgerald in gfx-rs/wgpu#4756
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature.
   By jimblandy in gfx-rs/wgpu#4761
 * #4769 Conditionally lift API logging from trace to info level
   By nical in gfx-rs/wgpu#4769
 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug
   By nical in gfx-rs/wgpu#4771
 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER`
   By teoxoy in gfx-rs/wgpu#4760
 * #4772 Downgrade resource lifetime management log level to trace.
   By nical in gfx-rs/wgpu#4772
 * #4765 Revamp Examples to Match Website
   By cwfitzgerald in gfx-rs/wgpu#4765
 * #4774 Update examples readme files
   By roffs in gfx-rs/wgpu#4774
 * #4781 remove_abandoned fix
   By gents83 in gfx-rs/wgpu#4781
 * #4777 Bump web-sys to 0.3.65
   By torokati44 in gfx-rs/wgpu#4777
 * #4780 Fixes for Skybox and All Examples
   By cwfitzgerald in gfx-rs/wgpu#4780
 * #4782 Remove resources ONLY when needed inside wgpu and not in user land
   By gents83 in gfx-rs/wgpu#4782
 * #4786 Don't keep a strong ref in storage for destroyed resources
   By gents83 in gfx-rs/wgpu#4786
 * #4795 Fix Arcanization changelog
   By a1phyr in gfx-rs/wgpu#4795
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4573 Support nv12 texture format
   By xiaopengli89 in gfx-rs/wgpu#4573
 * #4789 Bump js-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4789
 * #4784 Bump winit from 0.29.3 to 0.29.4
   By dependabot[bot] in gfx-rs/wgpu#4784
 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0
   By dependabot[bot] in gfx-rs/wgpu#4798
 * #4800 Bump web-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4800
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39
   By dependabot[bot] in gfx-rs/wgpu#4799
 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning)
   By Wumpf in gfx-rs/wgpu#4796
 * #4804 Add space to a comment inside make_spirv_raw
   By ComfyFluffy in gfx-rs/wgpu#4804
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message.
   By jimblandy in gfx-rs/wgpu#4805
 * #4801 update deno
   By crowlKats in gfx-rs/wgpu#4801
 * #4806 Fixes and changes to the documentation for increasing clarity
   By Blatko1 in gfx-rs/wgpu#4806
 * #4809 [naga wgsl-in] Use a better span for errors in constructors.
   By jimblandy in gfx-rs/wgpu#4809
 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages.
   By jimblandy in gfx-rs/wgpu#4808
 * #4822 Fix expected error message
   By teoxoy in gfx-rs/wgpu#4822
 * #4759 Add feature float32-filterable
   By almarklein in gfx-rs/wgpu#4759
 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3
   By dependabot[bot] in gfx-rs/wgpu#4813

Differential Revision: https://phabricator.services.mozilla.com/D195438

UltraBlame original commit: 985aabb5bf419ffcc9248010353ff190c225ba61
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 7, 2023
@marco-c
Bug 1868143 - Update wgpu to revision 767ac03245ee937d3dc552edc13fe…
f82008f 
…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler

# Changelog

 * #4708 Fix max_vertex_buffers validation
   By nical in gfx-rs/wgpu#4708
 * #4729 Remove expected failure on AMD/DX12 from msaa example
   By teoxoy in gfx-rs/wgpu#4729
 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals.
   By jimblandy in gfx-rs/wgpu#4711
 * #4736 Bump serde from 1.0.192 to 1.0.193
   By dependabot[bot] in gfx-rs/wgpu#4736
 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width.
   By jimblandy in gfx-rs/wgpu#4735
 * #4741 [naga] Fix type error in test.
   By jimblandy in gfx-rs/wgpu#4741
 * #4742 [naga]: Make snapshot tests include paths in errors.
   By jimblandy in gfx-rs/wgpu#4742
 * #4723 Test And Normalize Vertex Behavior on All Backends
   By cwfitzgerald in gfx-rs/wgpu#4723
 * #4746 Skip Flaky Test
   By cwfitzgerald in gfx-rs/wgpu#4746
 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings
   By bradwerth in gfx-rs/wgpu#4744
 * #4745 [naga wgsl-in] Test hex float suffix handling corner case.
   By jimblandy in gfx-rs/wgpu#4745
 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress>
   By nical in gfx-rs/wgpu#4737
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4701 [naga msl-out] Emit and init `struct` member padding always
   By ErichDonGubler in gfx-rs/wgpu#4701
 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations.
   By jimblandy in gfx-rs/wgpu#4733
 * #4734 [naga] Make compaction preserve named types, even if unused.
   By jimblandy in gfx-rs/wgpu#4734
 * #4752 Logging cleanups in device/global.rs
   By nical in gfx-rs/wgpu#4752
 * #4753 Fix Mac Event Loop
   By cwfitzgerald in gfx-rs/wgpu#4753
 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER
   By i509VCB in gfx-rs/wgpu#4754
 * #4748 Allow Tests to Expect Certain Panic or Validation Messages
   By cwfitzgerald in gfx-rs/wgpu#4748
 * #4756 Move to A Single Example Executable
   By cwfitzgerald in gfx-rs/wgpu#4756
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals.
   By jimblandy in gfx-rs/wgpu#4747
 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature.
   By jimblandy in gfx-rs/wgpu#4761
 * #4769 Conditionally lift API logging from trace to info level
   By nical in gfx-rs/wgpu#4769
 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug
   By nical in gfx-rs/wgpu#4771
 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER`
   By teoxoy in gfx-rs/wgpu#4760
 * #4772 Downgrade resource lifetime management log level to trace.
   By nical in gfx-rs/wgpu#4772
 * #4765 Revamp Examples to Match Website
   By cwfitzgerald in gfx-rs/wgpu#4765
 * #4774 Update examples readme files
   By roffs in gfx-rs/wgpu#4774
 * #4781 remove_abandoned fix
   By gents83 in gfx-rs/wgpu#4781
 * #4777 Bump web-sys to 0.3.65
   By torokati44 in gfx-rs/wgpu#4777
 * #4780 Fixes for Skybox and All Examples
   By cwfitzgerald in gfx-rs/wgpu#4780
 * #4782 Remove resources ONLY when needed inside wgpu and not in user land
   By gents83 in gfx-rs/wgpu#4782
 * #4786 Don't keep a strong ref in storage for destroyed resources
   By gents83 in gfx-rs/wgpu#4786
 * #4795 Fix Arcanization changelog
   By a1phyr in gfx-rs/wgpu#4795
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4794 Delete/rename now-unused gpu.rs
   By exrook in gfx-rs/wgpu#4794
 * #4573 Support nv12 texture format
   By xiaopengli89 in gfx-rs/wgpu#4573
 * #4789 Bump js-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4789
 * #4784 Bump winit from 0.29.3 to 0.29.4
   By dependabot[bot] in gfx-rs/wgpu#4784
 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0
   By dependabot[bot] in gfx-rs/wgpu#4798
 * #4800 Bump web-sys from 0.3.65 to 0.3.66
   By dependabot[bot] in gfx-rs/wgpu#4800
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls.
   By jimblandy in gfx-rs/wgpu#4743
 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39
   By dependabot[bot] in gfx-rs/wgpu#4799
 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning)
   By Wumpf in gfx-rs/wgpu#4796
 * #4804 Add space to a comment inside make_spirv_raw
   By ComfyFluffy in gfx-rs/wgpu#4804
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4803 `features`/`limits` refactors
   By teoxoy in gfx-rs/wgpu#4803
 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message.
   By jimblandy in gfx-rs/wgpu#4805
 * #4801 update deno
   By crowlKats in gfx-rs/wgpu#4801
 * #4806 Fixes and changes to the documentation for increasing clarity
   By Blatko1 in gfx-rs/wgpu#4806
 * #4809 [naga wgsl-in] Use a better span for errors in constructors.
   By jimblandy in gfx-rs/wgpu#4809
 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages.
   By jimblandy in gfx-rs/wgpu#4808
 * #4822 Fix expected error message
   By teoxoy in gfx-rs/wgpu#4822
 * #4759 Add feature float32-filterable
   By almarklein in gfx-rs/wgpu#4759
 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3
   By dependabot[bot] in gfx-rs/wgpu#4813

Differential Revision: https://phabricator.services.mozilla.com/D195438

UltraBlame original commit: 985aabb5bf419ffcc9248010353ff190c225ba61
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 11, 2024
@kpreid
wgpu: Remove Metal uniform padding workaround.
d36f5e6 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19 (not yet released as of this writing).
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 18, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
7e8d5d4 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 18, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
f6779cd 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 22, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
c8afb22 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 22, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
0a82250 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 22, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
8bdea84 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
kpreid added a commit to kpreid/all-is-cubes that referenced this pull request Jan 22, 2024
@kpreid
gpu: Remove Metal uniform padding workaround.
38afeda 
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
api: metal Issues with Metal area: naga back-end Outputs of naga shader conversion naga Shader Translator platform: macos Issues with integration with macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metal shader translation does not align vec3s to match std140
2 participants
@ErichDonGubler @teoxoy