Validate that a binding offset fits in the buffer #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jan 9, 2024
| if buffer.size < bb.offset { | ||
| return Err(Error::BindingRangeTooLarge { | ||
| buffer: bb.buffer_id, | ||
| range: bb.offset..bb.offset, |
There was a problem hiding this comment.
My only concern is that this faux range may make the error message very confusing for the user, as this range never actually shows up in their code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Crash found when running the CTS in Firefox.
Description
If the binding size is not specified we didn't validate that the offset was in the bounds of the buffer, causing an overflow panic on debug and UB/nonsense on release. This PR adds the missing validation.
Testing
Covered by the CTS
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.