Release GPU resources from device.trackers, not from lifetime_tracker. #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradwerth
force-pushed
the
releaseMoreGPUResources
branch
from
9c842b6
to
05f04f5
Compare
nical
approved these changes
Jan 22, 2024
nical
force-pushed
the
releaseMoreGPUResources
branch
from
c543a47
to
82db733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#4907
Description
This makes wgpu release all device-tracked GPU buffers and textures during "lose the device". Previously, wgpu only released buffers that had pending status changes in
life_tracker.Testing
Tested by bulk test runners like CTS, which should run out of memory less frequently.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.