Impl. const. eval. for yet more trivial component-wise numeric built-ins in WGSL #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: correctness
73 tasks
ErichDonGubler
force-pushed
the
builtins-const-eval-2
branch
2 times, most recently
from
c4df992
to
c9176fb
Compare
4 tasks
ErichDonGubler
added
area: naga processing
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
commented
Jan 26, 2024
ErichDonGubler
force-pushed
the
builtins-const-eval-2
branch
from
acdfc66
to
038b0d5
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-2
branch
from
038b0d5
to
119a549
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-2
branch
from
119a549
to
057f41f
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-2
branch
from
7e78aca
to
9753478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Resolves many more of the now-trivial-to-implement built-ins, as an iteration over #4879.
Description
Describe what problem this is solving, and how it's solved.
See above.
Testing
Explain how this change is tested.
The current form of this PR depends on our snapshot test coverage for
naga. I don't think it's complete; I'd be open to adding more coverage as part of this PR.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.