Separate native-only feature for wgpu::CommandEncoder::write_timestamp
#5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
changed the title
wgpu::CommandEncoder::write_timestampwgpu::CommandEncoder::write_timestamp
6 tasks
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Approving, conditional on style feedback being addressed and resolution of CI issues. I'm not concerned about the rest of the PR. Oh, except:
- Can we please file follow-up work to investigate switching
InstanceFlagstoenumset, per discussion in Matrix noting thatu128can be problem forweb*backends?
This comment was marked as resolved.
This comment was marked as resolved.
Wumpf
force-pushed
the
timestamp-in-encoders-feature
branch
from
0a4a214 to
00312e9
Compare
|
oops, messed up a feature check. But luckily the test prevent that from going in, phew |
Wumpf
force-pushed
the
timestamp-in-encoders-feature
branch
from
bc349b3 to
27d013e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
WebGPU no longer supports timestamps on encoder (the only kind supported now are the ones on render/compute passes), meaning we have to split up out
TIMESTAMP_QUERY_INSIDE_ENCODERSof the existingTIMESTAMP_QUERYfeature.Note that this gets our feature number at 64, meaning I had to switch the feature flag datatype to u128 (.. this will solve the problem once and for all! ;))
Testing
There's a test on timestamp that I ran on Mac. Change overall fairly straight forward, low risk.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.